formatters(image): prevent image size from displaying scientific notation #5059
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this PR was pending to fix it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3091
dupe #4459
- What I did
HumanSizeWithPrecision(which was configured to 3 significant digits) was replaced withHumanSize(which defaults to 4) in order to prevent scientific notation from appearing under certain edge cases. This is a known bug (docker/go-units#44) in the affected dependency.In practical terms, adjusting the precision from 3 to 4 should cause no issues with users' current expectations and usage of the cli.
- How to verify it
Regression tests implemented to prevent future breakage.
- Description for the changelog